-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PWA notice on light mode #1391
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
#app .dark_mode .pwa-toast { | ||
background-color: #15344a; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Light mode background already not opaque anyway. 🤷♂️ So changing this for dark mode only.
class="pwa-toast" | ||
title="Update" | ||
type="info" | ||
closable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make more sense to force update so, making this unclosable.
Graphite Merge Job Current status: ⛔ Merge stopped This pull request was previously queued to merge as part of a stack. It could not be merged because optional checks are failing. To continue, please 1) fix the tests and start a new merge or 2) manually merge past the failing tests. This comment was auto-generated by Graphite. Job Reference: CMJ76Nld0kihdwXeses7 |
2d27e90
to
729e23d
Compare
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: LOq9Fql0WFYMm3bFv4tx |
Codecov Report
@@ Coverage Diff @@
## main #1391 +/- ##
=======================================
Coverage 51.26% 51.26%
=======================================
Files 44 44
Lines 2915 2915
Branches 11 11
=======================================
Hits 1494 1494
Misses 1421 1421 Continue to review full report at Codecov.
|
No description provided.