Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PWA notice on light mode #1391

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

binhonglee
Copy link
Owner

No description provided.

Copy link
Owner Author

binhonglee commented Jul 24, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Comment on lines +17 to +19
#app .dark_mode .pwa-toast {
background-color: #15344a;
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light mode background already not opaque anyway. 🤷‍♂️ So changing this for dark mode only.

class="pwa-toast"
title="Update"
type="info"
closable
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make more sense to force update so, making this unclosable.

@binhonglee binhonglee marked this pull request as ready for review July 24, 2022 18:30
Copy link
Owner Author

binhonglee commented Jul 25, 2022

Graphite Merge Job

Current status: ⛔ Merge stopped

This pull request was previously queued to merge as part of a stack. It could not be merged because optional checks are failing. To continue, please 1) fix the tests and start a new merge or 2) manually merge past the failing tests.

This comment was auto-generated by Graphite.

Job Reference: CMJ76Nld0kihdwXeses7

@binhonglee binhonglee force-pushed the 07-24-Fix_PWA_notice_on_light_mode branch from 2d27e90 to 729e23d Compare July 25, 2022 03:22
Copy link
Owner Author

binhonglee commented Jul 25, 2022

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: LOq9Fql0WFYMm3bFv4tx

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1391 (729e23d) into main (008f3d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   51.26%   51.26%           
=======================================
  Files          44       44           
  Lines        2915     2915           
  Branches       11       11           
=======================================
  Hits         1494     1494           
  Misses       1421     1421           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daced5...729e23d. Read the comment docs.

@binhonglee binhonglee merged commit 728727f into main Jul 25, 2022
@binhonglee binhonglee deleted the 07-24-Fix_PWA_notice_on_light_mode branch July 25, 2022 03:32
github-actions bot added a commit that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant